pkg: revert to 19.2 protobuf order for compute_expr #47269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
reviewed
Apr 9, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/sqlbase/structured.proto, line 131 at r1 (raw file):
optional string compute_expr = 11; // Ids of sequences that the column owns. repeated uint32 owns_sequence_ids = 12 [(gogoproto.casttype) = "ID"];
There is no requirement for the fields to be in tag order. If this field logically belongs next to own_sequence_ids, shouldn't it be placed there?
Release note (bug fix): fix incompatibility with 19.2 nodes for tables with computed columns
jordanlewis
force-pushed
the
fix-compute-expr
branch
from
c3011fe
to
7bec52b
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47263
Release note (bug fix): fix incompatibility with 19.2 nodes for tables
with computed columns