ui: do not report errors for ranges with untrusted raft log size #48032
Conversation
|
This change is |
|
|
There was a problem hiding this comment.
@tbg can you remind me when the trusted bit is reset?
The new Size Trusted? line seems to be the only one with a question mark. It also seems redundant with the coloring of the previous row. This table is already quite overwhelming. Any interest in making the trusted thing a tool tip on a question mark in the greyed-out size cell? Then we could put more info in there too. Nobody understands the many peculiarities that this report can show any more; I think it'd be great to set a better precedent.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
|
❌ The GitHub CI (Cockroach) build has failed on bbce1804. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
darinpp
force-pushed
the
fix_false_raft_too_large
branch
from
bbce180
to
34209ad
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 34209ad1. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
LGTM
…On Mon, Apr 27, 2020 at 1:59 PM blathers-crl[bot] ***@***.***> wrote:
❌ The GitHub CI (Cockroach) build
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1903728&buildTypeId=Cockroach_UnitTests>
has failed on 34209ad1
<34209ad>
.
🦉 Hoot! I am a Blathers <https://github.com/apps/blathers-crl>, a bot
for CockroachDB <https://github.com/cockroachdb>. My owner is otan
<https://github.com/otan>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48032 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4ORJMB5XPZWMEE2F23ROXBZZANCNFSM4MQNTYQA>
.
|
darinpp
force-pushed
the
fix_false_raft_too_large
branch
from
34209ad
to
56dd469
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 56dd4694. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
darinpp
force-pushed
the
fix_false_raft_too_large
branch
2 times, most recently
from
7f78509
to
c6da58d
Compare
|
❌ The GitHub CI (Cockroach) build has failed on c6da58d8. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previosuly a raft log size that exceeded several times the truncation threshold will result in a "Raft too large" reported for each replica even though the Log Size is set to not be trusted. This lead to confusion from the customers as it seemed as if there is a problem. With this fix, the "Raft too large" is only reported if the raft log size is trusted. In the cases that it isn't trusted, the raft log size is now displayed grayed for each replica. This PR also removes the "Log Size Trusted?" from the range report and instead the grayed log size and a more detailed tooltip are used to indicate untrusted log size. Fixes cockroachdb#47569 Release note (admin ui change): Fixed a bug where "Raft log too large" was reported incorrectly for replicas for which the raft log size is not to be trusted.
darinpp
force-pushed
the
fix_false_raft_too_large
branch
from
c6da58d
to
7a7bf1a
Compare
|
bors r+ |
1 similar comment
|
bors r+ |
|
Already running a review |
|
grrr |
|
bors r+ |
Build succeeded |
Previosuly a raft log size that exceeded several times the truncation
threshold will result in a "Raft too large" reported for each replica even
though the Log Size is set to not be trusted.
This lead to confusion from the customers as it seemed as if there is a problem.
With this fix, the "Raft too large" is only reported if the raft log size is trusted.
In the cases that it isn't trusted, the raft log size is now displayed grayed for each replica.
This PR also removes the "Log Size Trusted?" from the range report and instead
the grayed log size is used to indicate untrusted log size.
Fixes #47569
Release note (admin ui change): Fixed a bug where "Raft log too large" was reported incorrectly for replicas for which the raft log size is not to be trusted.