Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: change default engine type from RocksDB to Pebble #48145

Merged
merged 2 commits into from May 9, 2020
Merged

storage: change default engine type from RocksDB to Pebble #48145

merged 2 commits into from May 9, 2020

Commits on May 9, 2020

  1. storage: change default engine type from RocksDB to Pebble 

    This flips the switch to use Pebble by default. This will cause all
tests which don't explicitly specify RocksDB (i.e. the vast majority) to
now use Pebble. One exception is certain roachtests which create store
directories using older versions of CRDB and then upgrade to the current
version. Those tests will continue to use RocksDB (for now) due to the
nature of how `--storage-engine=...` is "sticky" if not specified,
defaulting to the previously used storage engine.

Release note (general change): Change the default engine type for new
storage directories from RocksDB to Pebble. Existing stores will
continue to use the previously specified storage engine, and an explicit
specification (via `--storage-engine=...`) will override the default.
    @petermattis
    petermattis committed May 9, 2020
    Copy the full SHA
    4cb8298 View commit details
    Browse the repository at this point in the history

  2. roachtest: temporarily skip synctest as it is broken on Pebble 

    See cockroachdb#48603

Release note: None
    @petermattis
    petermattis committed May 9, 2020
    Copy the full SHA
    5d08f59 View commit details
    Browse the repository at this point in the history