Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove table comments in single rtt #48265

Merged
merged 1 commit into from May 9, 2020

Conversation

jordanlewis
Copy link
Member

Release note (performance improvement): DROP TABLE performance is
improved due to doing fewer roundtrips for object comment maintenance

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented May 1, 2020

❌ The GitHub CI (Cockroach) build has failed on fa1169f6.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link

blathers-crl bot commented May 1, 2020

❌ The GitHub CI (Cockroach) build has failed on 8960d513.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Release note (performance improvement): DROP TABLE performance is
improved due to doing fewer roundtrips for object comment maintenance
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 9, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented May 9, 2020

Build succeeded

@craig craig bot merged commit c1abb27 into cockroachdb:master May 9, 2020
@jordanlewis jordanlewis deleted the drop-table-comments branch May 12, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants