release-20.1: sql: fix casting of negative datums to decimals #48345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when negative intervals, timestamps, and timestamptzs were cast to decimals, the result was incorrect. The problem was due to the fact that for these negative values, Decimal.Coeff.neg was being set to true, while Decimal.Negative was false. As explained in the comment in decimal.go, "Coeff must be positive. If it is negative results may be incorrect and apd may panic." This commit fixes the problem by setting Decimal.Negative to true and Decimal.Coeff.neg to false when casting negative datums to decimals. Fixes cockroachdb#47327 Release note (bug fix): Fixed incorrect results that could occur when casting negative intervals or timestamps to type decimal.
|
This change is |
yuzefovich
approved these changes
May 4, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47483.
/cc @cockroachdb/release
Prior to this commit, when negative intervals, timestamps, and timestamptzs
were cast to decimals, the result was incorrect. The problem was due to the
fact that for these negative values,
Decimal.Coeff.negwas being set to true,while
Decimal.Negativewas false. As explained in the comment indecimal.go,"Coeff must be positive. If it is negative results may be incorrect and apd
may panic."
This commit fixes the problem by setting
Decimal.Negativeto true andDecimal.Coeff.negto false when casting negative datums to decimals.Fixes #47327
Release note (bug fix): Fixed incorrect results that could occur when
casting negative intervals or timestamps to type decimal.