release-20.1: sql: fix panic when SHOW RANGES is called with a virtual table #48347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
May 4, 2020
|
❌ The GitHub CI (Cockroach) build has failed on e0932ac8. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Prior to this commit, calling SHOW RANGES or SHOW RANGE FOR ROW with a virtual table caused a panic, since virtual tables have no ranges. This commit fixes the problem by returning an error instead of a panic. Fixes cockroachdb#44326 Release note (bug fix): Fixed a panic that could occur when SHOW RANGES or SHOW RANGE FOR ROW was called with a virtual table.
|
Sorry, had to change this to match #47516 PTAL |
RaduBerinde
approved these changes
May 5, 2020
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47500.
/cc @cockroachdb/release
Prior to this commit, calling
SHOW RANGESorSHOW RANGE FOR ROWwitha virtual table caused a panic, since virtual tables have no ranges.
This commit fixes the problem by returning an error instead of a panic.
Fixes #44326
Release note (bug fix): Fixed a panic that could occur when SHOW RANGES
or SHOW RANGE FOR ROW was called with a virtual table.