release-20.1: server: make SRV resolution for join list non-fatal #48349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, any other failure to do an SRV lookup for the join list than the "host not found" error would cause the resolution to stop. In case of that happening for all records, the node won't be unable to start. Actually, it is recommended to ignore errors from SRV lookups and continue with regular A lookup (https://tools.ietf.org/html/rfc2782). This PR makes that change. Fixes cockroachdb#47550 Release note (bug fix): makes SRV resolution non-fatal for join list records to align with the standard and improve reliability of node startup.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47735.
/cc @cockroachdb/release
Currently, any other failure to do an SRV lookup for the join list than the "host not found" error would cause the resolution to stop. In case of that happening for all records, the node won't be unable to start.
Actually, it is recommended to ignore errors from SRV lookups and continue with regular A lookup
(https://tools.ietf.org/html/rfc2782). This PR makes that change.
Fixes #47550
Release note (bug fix): makes SRV resolution non-fatal for join list records to align with the standard and improve reliability of node startup.