-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: remove typo in pg_catalog.pg_aggregate table population. #48351
sql: remove typo in pg_catalog.pg_aggregate table population. #48351
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
nit: could you please update the release note in the commit message and in the PR description so that it is like
Release note: None
For some context, we're using these release notes in the commit messages to auto-generate notes that will go out with a new release (after a tech writer reviews them), and if we have "Release note: None", such note is definitely ignored, but I'm not sure if that's the case if we have "Release note (sql change): None".
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
This PR corrects the typo introduced by following PR cockroachdb#48126 that is update reference of builtin function from `cume_dict` to `cume_dist`. Release note: None
6735aa0
to
ff7da97
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Sure, |
Thanks! bors r=yuzefovich |
Build succeeded |
This PR corrects the typo introduced by following PR
#48126 that is update reference of builtin function
from
cume_dict
tocume_dist
.Release note: None