Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove typo in pg_catalog.pg_aggregate table population. #48351

Conversation

abhishek20123g
Copy link
Contributor

@abhishek20123g abhishek20123g commented May 4, 2020

This PR corrects the typo introduced by following PR
#48126 that is update reference of builtin function
from cume_dict to cume_dist.

Release note: None

@blathers-crl
Copy link

blathers-crl bot commented May 4, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the X-blathers-triaged blathers was able to find an owner label May 4, 2020
@blathers-crl blathers-crl bot requested a review from yuzefovich May 4, 2020 16:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

nit: could you please update the release note in the commit message and in the PR description so that it is like

Release note: None

For some context, we're using these release notes in the commit messages to auto-generate notes that will go out with a new release (after a tech writer reviews them), and if we have "Release note: None", such note is definitely ignored, but I'm not sure if that's the case if we have "Release note (sql change): None".

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

This PR corrects the typo introduced by following PR
cockroachdb#48126 that is update reference of builtin function
from `cume_dict` to `cume_dist`.

Release note: None
@abhishek20123g abhishek20123g force-pushed the sql-populate-pg_catalog.pg_aggregate-table-correcting-typo branch from 6735aa0 to ff7da97 Compare May 4, 2020 16:32
@blathers-crl
Copy link

blathers-crl bot commented May 4, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@abhishek20123g
Copy link
Contributor Author

Sure,
Updated 😊

@yuzefovich
Copy link
Member

Thanks!

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented May 4, 2020

Build succeeded

@craig craig bot merged commit 62309f8 into cockroachdb:master May 4, 2020
@abhishek20123g abhishek20123g deleted the sql-populate-pg_catalog.pg_aggregate-table-correcting-typo branch May 6, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants