Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: fix output of pg_typeof to be compatible #48614

Merged
merged 1 commit into from
May 13, 2020

Conversation

jordanlewis
Copy link
Member

Previously, the builtin pg_typeof was returning a CockroachDB-specific
type string for each type. This is not quite correct - we want to return
the "SQL Standard Type Name" for each datatype to match what Postgres
does.

Release note (sql change): improve compatibility of pg_typeof builtin
function.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented May 8, 2020

❌ The GitHub CI (Cockroach) build has failed on cae8d6b8.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Previously, the builtin pg_typeof was returning a CockroachDB-specific
type string for each type. This is not quite correct - we want to return
the "SQL Standard Type Name" for each datatype to match what Postgres
does.

Release note (sql change): improve compatibility of pg_typeof builtin
function.
@jordanlewis
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 13, 2020

Build succeeded

@craig craig bot merged commit 25903a8 into cockroachdb:master May 13, 2020
@jordanlewis jordanlewis deleted the pg-typeof-fix branch May 13, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants