sql: introduce pg_extension schema #48754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on 4334103c. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Also added a barebones geography_columns, geometry_columns and spatial_ref_sys table definition which I will delegate to another reviewer - this bit is SQL Feature-y by itself :) Release note (sql change): Introduced the pg_extension virtual schema, which contains tables which are on the public schema when using postgres style extensions.
rohany
approved these changes
May 13, 2020
| @@ -132,7 +132,7 @@ query III colnames | |||
| SELECT * FROM bar | |||
| ---- | |||
| a b c | |||
| 1 2 4 | |||
| 1 2 5 | |||
There was a problem hiding this comment.
foo is CREATE TABLE foo (x, y, z) AS SELECT catalog_name, schema_name, sql_path FROM information_schema.schemata, and we added a new schema.
bar.c relies on count(*) from foo.
| @@ -103,7 +103,8 @@ INSERT INTO parse_test (geom, geog) VALUES | |||
| (ST_GeomFromGeoJSON('{"type":"Feature","geometry":{"type":"Point","coordinates":[1,2]},"properties":null}'::jsonb), ST_GeogFromGeoJSON('{"type":"Feature","geometry":{"type":"Point","coordinates":[1,2]},"properties":null}'::jsonb)), | |||
| (ST_GeomFromWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex')), ST_GeogFromWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex'))), | |||
| (ST_GeomFromWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex'), 3857), ST_GeogFromWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex'), 3857)), | |||
| (ST_GeomFromEWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex')), ST_GeogFromEWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex'))) | |||
| (ST_GeomFromEWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex')), ST_GeogFromEWKB(decode('0101000000000000000000F03F000000000000F03F', 'hex'))), | |||
There was a problem hiding this comment.
are these changes part of adding pg_extension?
There was a problem hiding this comment.
nah but it was an annoying rebase so i just moved this up from below.
|
bors r=rohany |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a barebones geography_columns, geometry_columns and
spatial_ref_sys table definition which I will delegate to another
reviewer - this bit is SQL Feature-y by itself :)
Release note (sql change): Introduced the pg_extension virtual schema,
which contains tables which are on the public schema when using postgres
style extensions.