release-20.1: sql: preserve zone configurations after a primary key change #48827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Fixes cockroachdb#48254. Release note (bug fix): This PR fixes a bug where changing the primary key of a table that had partitioned indexes could cause indexes to lose their zone configurations. In particular, the indexes that got rebuilt as part of a primary key change would keep their partitions but lose the zone configurations attached to those partitions.
rohany
force-pushed
the
backport20.1-48510
branch
from
b2cd9e6
to
8d2b7b6
Compare
|
cc @lucy-zhang can I get a stamp on this? I don't want to miss the 20.1.1 cut. |
thoszhang
approved these changes
May 15, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #48510.
/cc @cockroachdb/release
Fixes #48254.
Release note (bug fix): This PR fixes a bug where changing the primary
key of a table that had partitioned indexes could cause indexes to
lose their zone configurations. In particular, the indexes that got
rebuilt as part of a primary key change would keep their partitions
but lose the zone configurations attached to those partitions.