ui: fix network page render on missing localities #49138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was making assumptions that a multi-node cluster would have localities defined on the nodes. Without localities defined, the page would fail to render. Release note (admin ui change): Fixed a bug where a multi-node cluster without localities defined wouldn't be able to render the "Network Latency" page.
|
This change is |
vladlos
approved these changes
May 18, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was making assumptions that a multi-node cluster
would have localities defined on the nodes. Without
localities defined, the page would fail to render.
Release note (admin ui change): Fixed a bug where a multi-node
cluster without localities defined wouldn't be able to
render the "Network Latency" page.
Part of #48353.