Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/demo: fix \demo node restart #49382

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

otan
Copy link
Contributor

@otan otan commented May 21, 2020

Also re-enabled the tcl test, as TLS 1.3 has been disabled.

Resolves #49381

Release note (bug fix): Fixed a bug where \demo node restart would not
work due to an invalid certificate directory.

@otan otan requested a review from knz May 21, 2020 17:00
@otan otan requested a review from a team as a code owner May 21, 2020 17:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you 💯

@knz knz added this to In progress in SQL CLI (demo + sql + workload + dump) via automation May 21, 2020
Also re-enabled the tcl test, as TLS 1.3 has been disabled.

Release note (bug fix): Fixed a bug where `\demo node restart` would not
work due to an invalid certificate directory.
@otan
Copy link
Contributor Author

otan commented May 21, 2020

bors r=knz

tftr! examples-orms flake in the red.

@craig
Copy link
Contributor

craig bot commented May 21, 2020

Build succeeded

@craig craig bot merged commit 8ad6545 into cockroachdb:master May 21, 2020
SQL CLI (demo + sql + workload + dump) automation moved this from In progress to Done May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

cockroach demo can't restart a node
3 participants