Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add the max/min aggregations on ENUMs #49558

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

rohany
Copy link
Contributor

@rohany rohany commented May 26, 2020

Fixes #48370.

Release note (sql change): Add the max/min aggregation on ENUM types.

@rohany rohany requested a review from yuzefovich May 26, 2020 16:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rohany
Copy link
Contributor Author

rohany commented May 26, 2020

Depends on #49530

Fixes cockroachdb#48370.

Release note (sql change): Add the max/min aggregation on ENUM types.
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rohany
Copy link
Contributor Author

rohany commented May 27, 2020

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented May 27, 2020

Build succeeded

@craig craig bot merged commit d8a0f6c into cockroachdb:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: support enums in the max/min aggregate functions
3 participants