builtins: add missing UnwrapDatum call and change panics to error #49601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Not sure how to add a test for this, would appreciate any suggestions. |
|
DOidWrapper is only used for Names. Try passing a Name into one of these casts, maybe? |
|
Done |
|
Friendly ping |
yuzefovich
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)
pkg/sql/logictest/testdata/logic_test/pg_builtins, line 18 at r1 (raw file):
0 # Regression test for https://github.com/cockroachdb/cockroach/issues/49072.
nit: I think we tend to use short form #49072.
|
LGTM, thanks for adding the test! |
getNameForArg does not handle tree.DOidWrappers. The assumption in this code is that the datum gets unwrapped before calling this code. This commit adds a missing UnwrapDatum call and changes an unhandled type panic to an error instead. Release note (bug fix): a panic observed as "unexpected arg type tree.DOidWrapper" has been fixed.
asubiotto
commented
Jun 2, 2020
There was a problem hiding this comment.
TFTRs
bors r=yuzefovich,jordanlewis
Reviewable status:
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getNameForArg does not handle tree.DOidWrappers. The assumption in this code is
that the datum gets unwrapped before calling this code. This commit adds a
missing UnwrapDatum call and changes an unhandled type panic to an error
instead.
Release note (bug fix): a panic observed as "unexpected arg type
tree.DOidWrapper" has been fixed.
Closes #43166