roachtest: don't run schema change workload on 19.2 releases #49662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
spaskob
changed the title
ajwerner
reviewed
May 28, 2020
There was a problem hiding this comment.
Just commentary nits. I think the release note should say 19.2 instead of 19.0
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @spaskob)
pkg/cmd/roachtest/mixed_version_schemachange.go, line 76 at r1 (raw file):
schemaChangeStep := runSchemaChangeWorkloadStep(maxOps) if buildVersion.Major() < 20 { // Schema change workload is meant to run only on versions 19.x or higher.
19.2?
pkg/cmd/roachtest/mixed_version_schemachange.go, line 78 at r1 (raw file):
// Schema change workload is meant to run only on versions 19.x or higher. // If the main version is below 20.0 then then predecessor version is // below 19.0.
is below 19.2?
…eleases Fixes cockroachdb#47024. Release note (bug fix): The schema change workload is meant for testing the behavior of schema changes on clusters with nodes with min version 19.2. It will deadlock on earlier versions.
spaskob
changed the title
|
Thanks of course - I completely blanked there. |
ajwerner
approved these changes
May 28, 2020
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47024.
Release note (bug fix):
The schema change workload is meant for testing the behavior of schema
changes on clusters with nodes with min version 19.2. It will deadlock
on earlier versions.