sql: allow NULL IN <subquery> to typecheck #49723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (sql change): Previously, using NULL (or tuples containing NULLs) as the left-hand-side of an IN operator would not typecheck unless the NULLs were explicitly casted. Now, the casting is not required.
|
This change is |
jordanlewis
approved these changes
May 30, 2020
|
tftr! bors r=jordanlewis |
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 10, 2020
49814: sql: handle tuples with nulls for IN operator r=RaduBerinde a=rafiss
A previous change had allowed any query of the form <left> IN <subquery>
to typecheck as long as <left> is NULL or a tuple containing any NULLS.
This erroneously allowed something like `('s', NULL) IN (1, 2)` to
typecheck. Now, this is fixed, by making sure all the non-null tuple
elements have the same type.
A release note is omitted as this fixes a bug that is only present in
non-published versions of CockroachDB.
See #49723 and #49767 (review)
Release note: None
50011: sql: timestamp should accept DB2 formatted timestamps r=otan a=Arun4rangan
fixes : #49768
This PR adds additional extracting field logics that
allow db2 formatted timesstamps to be parsed.
Release note (sql change): The pgdate util can now parse
db2 formatted timestamps. This can be used to import db2 dumps.
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Arun Ranganathan <arun.ranga@hotmail.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49651
Release note (sql change): Previously, using NULL (or tuples
containing NULLs) as the left-hand-side of an IN operator would not
typecheck unless the NULLs were explicitly casted. Now, the casting is
not required.