[wip,dnr] *: introduce decommissioning bit #49850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
irfansharif
force-pushed
the
200529.decommissioning-state
branch
from
74aea99
to
32cd5fe
Compare
Fixes cockroachdb#38308 Updates to the liveness records are done as CPuts. Before this patch, the CPuts' expected value was the re-marshaled proto with the previous version. As cockroachdb#38308 explains, that's a bad practice since it prevents the proto's encoding to change in any way (e.g. fields can't be removed). Instead, this patch moves to keeping track of the raw bytes that have been read from the DB, besides the unmarshalled liveness protos. The raw bytes are used as the expected values. Release note: None
…ster (missing tests)
- [x] SetDraining absorbs from existing liveness into current proto. - [x] SetDecommissioning absorbs from existing liveness into current proto. - [x] Heartbeat absorbs from existing liveness into current proto. - [x] IncrementEpoch absorbs from existing liveness into current proto.
irfansharif
force-pushed
the
200529.decommissioning-state
branch
from
32cd5fe
to
797b95a
Compare
Release note: None
irfansharif
force-pushed
the
200529.decommissioning-state
branch
2 times, most recently
from
3d0c363
to
fdde6a0
Compare
Release note (<category, see below>): <what> <show> <why>
irfansharif
force-pushed
the
200529.decommissioning-state
branch
from
fdde6a0
to
251678f
Compare
|
Cleaned up in #50329. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't look, running CI.