sql: fix cast from string to array with width #50153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
reviewed
Jun 12, 2020
pkg/sql/sem/tree/parse_string.go
Outdated
| // If the string type specifies a limit we truncate to that limit: | ||
| // 'hello'::CHAR(2) -> 'he' | ||
| // This is true of all the string type variants. | ||
| if t.Width() > 0 && int(t.Width()) < len(s) { |
There was a problem hiding this comment.
interesting that parsing and storing strings that are too long have different results.
otan=# create temp table a (a varchar(1));
CREATE TABLE
otan=# insert into a values ('123');
ERROR: value too long for type character varying(1)
Should this be rune count like we do here:
?There was a problem hiding this comment.
Hmm. I copied this from PerformCast (string->string case). I think you're right though, postgres docs say that the limit is n "characters (not bytes)".
|
I will open a separate PR to fix the unicode stuff. And yeah, we should backport both (I already added the backport labels). |
|
Opened #50156. I will rebase this on top of that. |
RaduBerinde
force-pushed
the
fix-strarr-cast
branch
from
49ff117
to
78cdbe5
Compare
The code that performs a cast from string to array doesn't take into account the width of the string type it is producing. This doesn't show up when the input is a literal constant because the constant is first parsed as an array of (vanilla) strings which is then subjected to a cast (to array of strings with width). Fixes cockroachdb#50132. Release note (bug fix): Fixed some cases where casting a string to a width-limited string array was not truncating the string.
RaduBerinde
force-pushed
the
fix-strarr-cast
branch
from
78cdbe5
to
f0cfa78
Compare
|
bors r+ |
This was referenced Jun 12, 2020
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that performs a cast from string to array doesn't take into account the
width of the string type it is producing. This doesn't show up when the input is
a literal constant because the constant is first parsed as an array of (vanilla)
strings which is then subjected to a cast (to array of strings with width).
Fixes #50132.
Release note (bug fix): Fixed some cases of casting a string to a width-limited
string array.