release-20.1: opt: bugfix to virtual table scans #50843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
approved these changes
Jun 30, 2020
Previously, the optimizer exposed the hidden virtual table primary key column from scans, even though this column has no value and is not usable. This caused issues with some complex metadata queries. Now, the optimizer doesn't advertise this column, resolving the issue. Release note (bug fix): some pg_catalog queries that previously returned an error like "crdb_internal_vtable_pk column not allowed" now work again.
rafiss
force-pushed
the
backport20.1-50682
branch
from
68ab0b4
to
7f9dd3f
Compare
|
@jordanlewis it looks like I actually had to remove the diff in Does that make sense to you? |
|
No idea :/ @RaduBerinde what do you think? |
RaduBerinde
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #50682.
/cc @cockroachdb/release
Previously, the optimizer exposed the hidden virtual table primary key
column from scans, even though this column has no value and is not
usable. This caused issues with some complex metadata queries.
Now, the optimizer doesn't advertise this column, resolving the issue.
Closes #50157.
Release note (bug fix): some pg_catalog queries that previously returned
an error like "crdb_internal_vtable_pk column not allowed" now work
again.