wip: fatal stats mismatch #51808
Open
wip: fatal stats mismatch #51808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madelineliao
requested review from
a team and
miretskiy
and removed request for
a team
|
This change is |
Previously, the user would have to specify both the source and detination args when using `userfile upload`. This change tweaks the semantics to be as follows: - Users must specify a source path. - If the user does not specify a destination URI/path, we use the default URI scheme and host, and the basename from the source arg as the path. - If the destination is a well-formed userfile URI of the form userfile://db.schema.tablename_prefix/path/to/file, then we use that as the final URI. - If destination is not a well-formed userfile URI, we use the default userfile URI schema and host, and the destination as the path. File paths are never cleaned during upload or interaction with the UserFileStorage. Thus, the filename is the exact string represented by the path of the constructed userfile URI. This is in keeping with the semantics of s3 and gcsutil. To prevent user surprises we still reject constructs where the URI post normalization != URI pre normalization. egs: test/./test.csv or test/../../test.csv Release note (cli change): Improves the user semantics for `userfile upload` by supporting different patterns of specifying the source and destination CLI args. The source arg is required, while the destination arg is now optional.
My latest change in this area broke Nathan's previous fix. This commit reverts it. Release note: None
Release note: None
madelineliao
force-pushed
the
fatal-stats-mismatch
branch
from
c1cf61c
to
27383b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore, testing what happens if
fatalOnStatsMismatchis set totrue