Commits on Jul 23, 2020

1. kvserver: don't panic on wto after committed txn …

   In cockroachdb#50317 we're getting reports of an assertion firing telling us that a
   transaction has moved to the STAGING or COMMITTED state but there's also
   a WriteTooOldError to return to the client. This seems bad, and I can't
   figure out how it happens. EndTxn, which moves the txn to these states,
   is supposed to notice the WriteTooOld field on the baHeader.Txn and not
   do that transition. All the reports seem to be in the context of
   UPSERTs.
   
   This patch changes the assertion from a Fatal to just a sentry report,
   and includes more info in the report. The hope is that this turns out to
   be benign, related to the STAGING state.
   
   Touches cockroachdb#50317
   
   Release note: An unknown condition previously crash with the message
   "committed txn with writeTooOld err" now no longer crashes a node;
   instead an error message is printed to the logs asking for help in the
   investigation.

   

   andreimatei committed Jul 23, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 752f92e
   • Browse repository at this point

   Copy the full SHA

   752f92e View commit details

   Browse the repository at this point in the history