release-20.1: util/tracing: fix DistSQL trace collection #51845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreimatei
force-pushed
the
backport20.1-50913
branch
from
e9581b1
to
4535950
Compare
RaduBerinde
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Before this patch, the collection of traces from remote DistSQL flows was broken: the traces for the remote processors were collected as orphans. The spans corresponding to each processor were collected with a missing parent - the span corresponding to the SetupFlow RPC which creates the processor (the relationship there is a FollowsFrom because the execution of the processors is generally async wrt the RPC). This was causing the Recording.String() method to ignore them - it was simply skipping orphans. Release note (bug fix): A bug causing traces collected through the sql.trace.txn.enable_threshold setting to be sometimes incomplete was fixed.
andreimatei
force-pushed
the
backport20.1-50913
branch
from
4535950
to
c8151d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #50913.
/cc @cockroachdb/release
Before this patch, the collection of traces from remote DistSQL flows
was broken: the traces for the remote processors were collected as
orphans. The spans corresponding to each processor were collected with a
missing parent - the span corresponding to the SetupFlow RPC which
creates the processor (the relationship there is a FollowsFrom because
the execution of the processors is generally async wrt the RPC). This
was causing the Recording.String() method to ignore them - it was simply
skipping orphans.
Release note (bug fix): A bug causing traces collected through the
sql.trace.txn.enable_threshold setting to be sometimes incomplete was
fixed.