release-20.1: backupccl: stop reading on MutationJobs on RESTORE #51925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
thoszhang
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
This change stops reading the MutationJobs field on table descriptors that we are importing. It previously assumed that the MutationsJobs and Mutations remain in sync. However, in practice there are descriptors where this is not the case and RESTORE should no longer rely on this assumption. Release note (bug fix): Increase robustness of restore against descriptors which may be in an unexpected state.
pbardea
force-pushed
the
backport20.1-51848
branch
from
6abf89c
to
5f7a299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #51848.
/cc @cockroachdb/release
This change stops reading the MutationJobs field on table descriptors
that we are importing. It previously assumed that the MutationsJobs and
Mutations remain in sync. However, in practice there are descriptors
where this is not the case and RESTORE should no longer rely on this
assumption.
Release note (bug fix): Increase robustness of restore against
descriptors which may be in an unexpected state.