backupccl: stop blocking backup/restore jobs on client disconnect #51999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
do we need to do RESTORE too? |
|
Yep, was going to follow up in a separate PR - but I may as well as bundle it with this one. Will push the changes here. |
|
Updated with RESTORE, RFAL. |
Previously, a backup job whose client disconnect might have blocked on sending its results to the resultCh (and thus block forever). This commit allows these jobs to complete. Release note (bug fix): Previously, a BACKUP job would block once it finished backing up the data.
This commit prevents RESTORE from blocking when sending its results back over resultCh if the client that started the job disconnects. Release note (bug fix): Previously, RESTORE would sometimes block at the end of the job when sending its results back if the connection that started the job disconnected. This is now fixed.
pbardea
changed the title
dt
approved these changes
Jul 28, 2020
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a backup/restore job whose client disconnect might have blocked on
sending its results to the resultCh (and thus block forever). This
commit allows these jobs to complete.
Release note (bug fix): Previously, a BACKUP/RESTORE jobs would
sometimes block once it finished executing the job. This is now fixed.