release-20.1: pgwire: remove left over types refactor artifact #52351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Also, add a regression test to make sure type OIDs are reported correctly in the pgwire RowDescription. Release note (bug fix): Type OIDs in the result metadata were incorrect for the bit, bpchar, char(n), and varchar(n) types, as well as the corresponding array types. They are now correct.
rafiss
force-pushed
the
backport20.1-44471
branch
from
d310bc3
to
2edc18c
Compare
jordanlewis
approved these changes
Aug 4, 2020
RaduBerinde
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #51911
/cc @cockroachdb/release
See #51360
Also, add a regression test to make sure type OIDs are reported
correctly in the pgwire RowDescription.
Release note (bug fix): Type OIDs in the result metadata were incorrect
for the bit, bpchar, char(n), and varchar(n) types, as well as the
corresponding array types. They are now correct.