release-20.1: pgwire: trim statements past the conn executor's rewind pos eagerly #52402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM
…On Wed, Aug 5, 2020 at 8:45 AM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/52402>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#52402 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4LXPWXJYABGLWWCFX3R7FH77ANCNFSM4PVN6PMA>
.
|
asubiotto
force-pushed
the
backport20.1-48859
branch
from
d276048
to
4472d7a
Compare
|
Initial failure was a weird execution timeout that seems to have been making the rounds. Reran TC manually and got a green CI but doesn't look like the dependency got updated. Triggering a new run with the same commit but new sha. |
asubiotto
force-pushed
the
backport20.1-48859
branch
2 times, most recently
from
f2ce054
to
b8a995d
Compare
Previously, the conn executor held on to all executed statements in case they needed to be retried. These would only be discarded once the transaction committed. This could lead to a memory blowup in some cases. With the knowledge that statements whose results have been returned cannot be retried, this commit eagerly discards those statements every time a command is executed rather than waiting for the transaction to commit. Release note (bug fix): executing a large number of statements in a transaction without committing could previously crash a cockroach server, this is now fixed.
asubiotto
force-pushed
the
backport20.1-48859
branch
from
b8a995d
to
02b62be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #48859.
/cc @cockroachdb/release
Previously, the conn executor held on to all executed statements in case they
needed to be retried. These would only be discarded once the transaction
committed. This could lead to a memory blowup in some cases.
With the knowledge that statements whose results have been returned cannot be
retried, this commit eagerly discards those statements every time a command is
executed rather than waiting for the transaction to commit.
Release note (bug fix): executing a large number of statements in a transaction
without committing could previously crash a cockroach server, this is now
fixed.
Addresses #47969