Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/pgwire: atttypmod of arrays should be the same as array contents #52428

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 5, 2020

fixes #52414

This matches the Postgres behavior.

Release note (sql change): The value of pg_class.atttypmod and the
TypeModifier in the RowDescription for array columns is now the same as
the type modifier of the type of the array contents. This enhances
compatibility with the Postgres wire protocol.

@rafiss rafiss requested a review from rohany August 5, 2020 20:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@rohany rohany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a logictest like in the issue as well

This matches the Postgres behavior.

Release note (sql change): The value of pg_class.atttypmod and the
TypeModifier in the RowDescription for array columns is now the same as
the type modifier of the type of the array contents. This enhances
compatibility with the Postgres wire protocol.
@rafiss
Copy link
Collaborator Author

rafiss commented Aug 6, 2020

bors r=rohany

@craig
Copy link
Contributor

craig bot commented Aug 6, 2020

Build failed:

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 6, 2020

bors r=rohany

@craig
Copy link
Contributor

craig bot commented Aug 6, 2020

Build succeeded:

@craig craig bot merged commit f6aea21 into cockroachdb:master Aug 6, 2020
@rafiss rafiss deleted the array-atttypmod branch August 11, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql, pgwire: array types should have the same type modifier as the array contents
3 participants