importccl: fix case sensitive INSERT INTO column names in PGDUMP #52485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otan
requested review from
a team and
adityamaru
and removed request for
a team
|
This change is |
adityamaru
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
thanks! bors r=adityamaru |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like. |
Tested by uncommenting out the skip and re-commenting it afterwards. Release note (sql change, bug fix): When using `IMPORT PGDUMP` with `INSERT INTO` clauses, specifying a column name that is case sensitive (e.g. `"cApItAls"`) would previously error specifying the column name was not found. This has been rectified.
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #52382
Tested by uncommenting out the skip and re-commenting it afterwards.
Release note (sql change, bug fix): When using
IMPORT PGDUMPwithINSERT INTOclauses, specifying a column name that is case sensitive(e.g.
"cApItAls") would previously error specifying the column namewas not found. This has been rectified.