importccl: disable import with user defined schemas #52729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Aug 12, 2020
pkg/ccl/importccl/import_stmt.go
Outdated
| // Due to how we generate and rewrite descriptor ID's for import, we run | ||
| // into problems when using user defined schemas. | ||
| if parentSchemaID != keys.PublicSchemaID { | ||
| return errors.Newf("cannot use IMPORT with a user defined schema; user IMPORT INTO instead") |
There was a problem hiding this comment.
nit: s/user/use/ or, better yet create table with CREATE TABLE and then IMPORT INTO it instead
Release note (enterprise change): Cannot use `IMPORT` to create tables in user defined schemas. Users should instead create the table with `CREATE TABLE` and then use `IMPORT INTO`.
|
Updated the release note and error message bors r+ |
|
Build succeeded: |
jbowens
added a commit
to jbowens/pebble
that referenced
this pull request
Sep 29, 2020
A database that was created using RocksDB or a previous version of Pebble does not guarantee that its closed WALs were closed cleanly. Detect these cases by the absence of a special private 'strict_wal_tail' option. If this special option is missing from the OPTIONS file, interpret WALs permissively as they're interpreted in the RocksDB and Pebble versions that wrote them. See cockroachdb/cockroach#52729.
jbowens
added a commit
to jbowens/pebble
that referenced
this pull request
Sep 30, 2020
A database that was created using RocksDB or a previous version of Pebble does not guarantee that its closed WALs were closed cleanly. Detect these cases by the absence of a special private 'strict_wal_tail' option. If this special option is missing from the OPTIONS file, interpret WALs permissively as they're interpreted in the RocksDB and Pebble versions that wrote them. See cockroachdb/cockroach#52729.
jbowens
added a commit
to cockroachdb/pebble
that referenced
this pull request
Sep 30, 2020
A database that was created using RocksDB or a previous version of Pebble does not guarantee that its closed WALs were closed cleanly. Detect these cases by the absence of a special private 'strict_wal_tail' option. If this special option is missing from the OPTIONS file, interpret WALs permissively as they're interpreted in the RocksDB and Pebble versions that wrote them. See cockroachdb/cockroach#52729.
jbowens
added a commit
to jbowens/pebble
that referenced
this pull request
Sep 30, 2020
A database that was created using RocksDB or a previous version of Pebble does not guarantee that its closed WALs were closed cleanly. Detect these cases by the absence of a special private 'strict_wal_tail' option. If this special option is missing from the OPTIONS file, interpret WALs permissively as they're interpreted in the RocksDB and Pebble versions that wrote them. See cockroachdb/cockroach#52729.
jbowens
added a commit
to cockroachdb/pebble
that referenced
this pull request
Sep 30, 2020
A database that was created using RocksDB or a previous version of Pebble does not guarantee that its closed WALs were closed cleanly. Detect these cases by the absence of a special private 'strict_wal_tail' option. If this special option is missing from the OPTIONS file, interpret WALs permissively as they're interpreted in the RocksDB and Pebble versions that wrote them. See cockroachdb/cockroach#52729.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (enterprise change): Cannot use
IMPORTto create tablesin user defined schemas. Users should instead create the table with
CREATE TABLEand then useIMPORT INTO.