parser, backupccl: support running RESTORE in explicit txn #52779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DETACHED option to the list of allowed RESTORE options. This option requests the restore to run in detached mode: that is, the restore statement should not block, and instead simply return the job id. Release note: None
Allow execution of RESTORE statement under explicit transaction, provided the "DETACHED" option is specified: RESTORE FROM <location_uri> ... WITH DETACHED When restore runs in detached mode, we do not wait for the job completion. Instead, we return the job id to the caller, and the job executes asynchronously. Release note (enterprise change): RESTORE can now run in "detached" mode. That is, we do not wait for the RESTORE job to finish. Instead, the job ID is returned immediately, and the job itself runs in background.
|
This change is |
miretskiy
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 3 of 3 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! bors r=miretskiy |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50735