release-20.1: Check value of gc.ttlseconds before rendering to prevent TypeError #52813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2020 09:54
In a reported case from a customer, `zone_config.gc` is undefined and accessing `ttl_seconds` on a null threw an error that stopped page rendering. I'm adding a lodash/get call here with `null` as a default return to prevent a TypeError. This is generally a good idea whenever you are accessing anything that could be undefined in javascript. Release note: None
As of TypeScript 3.7, the optional chaining operator provides roughly the same purpose as lodash/get (with better syntax in my opinion). I am removing get() and instead depending on an optional chain. There was also concern about the correctness of displaying `gc.ttlseconds` as a null value, which is valid. The error I am seeking to prevent here is that `gc` is null or undefined, and so if there is no `gc` value then I am instead choosing not to display a value at all. Release note (bug fix): don't display a value for gc.ttlseconds if not set
|
This change is |
dhartunian
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #52721.
/cc @cockroachdb/release
In a reported case from a customer,
zone_config.gcis undefined andaccessing
ttl_secondson a null threw an error that stopped pagerendering.
I'm adding a lodash/get call here with
nullas a default return toprevent a TypeError. This is generally a good idea whenever you are
accessing anything that could be undefined in javascript.