parser,backupccl: add BACKUP INTO 'subdir' IN x #53139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Will rebase once #53060 is merged in. |
adityamaru
force-pushed
the
backup-improvement
branch
from
e586c74
to
8e810d2
Compare
dt
approved these changes
Aug 21, 2020
|
Oh, and I missed on first pass, but any addition to sql.y should be covered by cases in parse_test.go (they're very easy to add though) |
adityamaru
force-pushed
the
backup-improvement
branch
from
8e810d2
to
e20dfbe
Compare
dt
approved these changes
Aug 21, 2020
This change allows a user to specify a particular subdirectory of x to write their BACKUPs too. The semantics of determining whether it will be a full or incremental BACKUP are untouched. Example query: `BACKUP INTO 'foo' IN 'nodelocal://0/bar'` would write the BACKUP data and manifest files to `extern/bar/foo/`. The LATEST file would be written to `extern/bar/` and would point to `/foo/`. This change also modifies how we display the BACKUP statements in the job description. - `BACKUP TO x` (remains unchanged) -> `BACKUP TO x` - `BACKUP INTO x` -> `BACKUP INTO 'resolved-subdir' IN x` - `BACKUP INTO LATEST IN x` -> `BACKUP INTO 'value-in-LATEST' IN x` - `BACKUP INTO 'foo' IN x` -> `BACKUP INTO 'foo' IN x` Release note (sql change): Users can now specify which subdirectory they wish to write a BACKUP to, via `BACKUP INTO 'subdir' IN x`. This will write BACKUP data to `x/subdir/`.
adityamaru
force-pushed
the
backup-improvement
branch
from
e20dfbe
to
6ce964e
Compare
|
TFTR! bors=dt |
|
bors r=dt |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52929