Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: miscellaneous fixes to the CONVERT TO SCHEMA command #53564

Merged
merged 1 commit into from Sep 1, 2020
Merged

sql: miscellaneous fixes to the CONVERT TO SCHEMA command #53564

merged 1 commit into from Sep 1, 2020

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Aug 27, 2020 •
edited

Fixes #53563.

Release justification: low risk updates to new functionality
Release note (sql change): Disallow the CONVERT TO SCHEMA command on
the current database.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajwerner
ajwerner approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @solongordon)

@rohany
Copy link
Contributor Author

rohany commented Aug 31, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build failed:

@rohany
Copy link
Contributor Author

rohany commented Aug 31, 2020

bors r+

@otan
Copy link
Contributor

otan commented Aug 31, 2020

bors r-

merge conflict

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Canceled.

@rohany
sql: miscellaneous fixes to the CONVERT TO SCHEMA command
61eb6af 
Release justification: low risk updates to new functionality
Release note (sql change): Disallow the `CONVERT TO SCHEMA` command on
the current database.
@rohany
Copy link
Contributor Author

rohany commented Sep 1, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 1, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 1, 2020

Build succeeded:

@craig craig bot merged commit fe3d024 into cockroachdb:master Sep 1, 2020
@jseldess jseldess mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

@solongordon solongordon Awaiting requested review from solongordon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow converting database to schema for the current database
4 participants
@rohany @cockroach-teamcity @otan @ajwerner