kvserver: limit the frequency at which system config updates enqueue … #53603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replicas This has a shockingly profound impact on the runtime of ORM tests. This PR is my lower-risk, less fancy implementation of this functionality. There is another inbound PR that permits bursting. Release justification: low risk, high benefit changes to existing functionality Release note (performance improvement): Limited the frequency of an expensive operation due to schema changes making workload which perform schema changes at a high rate less resource intensive.
|
This change is |
|
Prior to this change, over 70% of the CPU utilization of the
|
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Aug 31, 2020
…replicas This has a shockingly profound impact on the runtime of ORM tests. This PR is a fancier implementation of cockroachdb#53603 that permits bursting and makes setting a relatively low rate feel less risky in the face of a small burst of changes. Release justification: low risk, high benefit changes to existing functionality Release note (performance improvement): Limited the frequency of an expensive operation due to schema changes making workload which perform schema changes at a high rate less resource intensive.
|
In practice I think #53605 is a much better change. This change is problematic in the face of small bursts of changes. |
|
Closing in favor of #53605. |
craig bot
pushed a commit
that referenced
this pull request
Aug 31, 2020
53578: rfc: mark partial index RFC as complete r=rytaft a=mgartner Release justification: This commit updates an RFC which is a non-production code change. Release note: None 53605: quotapool,kvserver: extend quotapool.RateLimit, rate limit queue addition in SystemConfigUpdate r=knz a=ajwerner See individual commits. This PR is a fancier implementation of #53603 that permits bursting and makes setting a relatively low rate feel less risky in the face of a small burst of changes. Release justification: low risk, high benefit changes to existing functionality Release note (performance improvement): Limited the frequency of an expensive operation due to schema changes making workload which perform schema changes at a high rate less resource intensive. 53647: *: bump twpayne/go-geom@1.3.5, geos to include POINT EMPTY fix r=sumeerbhola a=otan * Bumps twpayne/go-geom to resolve an issue with WKT encoding involving empty collection points. * Bumps GEOS to handles POINT EMPTY correctly. Resolves #53631. Resolves #53632. Release justification: low risk updates to new functionality Release note: None Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…replicas
This has a shockingly profound impact on the runtime of ORM tests.
This PR is my lower-risk, less fancy implementation of this functionality.
There is another inbound PR that permits bursting.
Release justification: low risk, high benefit changes to existing functionality
Release note (performance improvement): Limited the frequency of an expensive
operation due to schema changes making workload which perform schema changes
at a high rate less resource intensive.