Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: de-experimentalize user defined schemas #53674

Merged
merged 1 commit into from Aug 31, 2020

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Aug 31, 2020

Release justification: low-risk update to new functionality
Release note (sql change): De-experimentalize user defined schemas.

Release justification: low-risk update to new functionality
Release note (sql change): De-experimentalize user defined schemas.
@rohany rohany requested review from ajwerner, thoszhang and a team August 31, 2020 15:46
@rohany rohany requested a review from a team as a code owner August 31, 2020 15:46
@rohany rohany requested review from miretskiy and removed request for a team August 31, 2020 15:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@thoszhang thoszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 21 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @miretskiy)

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @miretskiy)

@rohany
Copy link
Contributor Author

rohany commented Aug 31, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build succeeded:

@craig craig bot merged commit 42e73f7 into cockroachdb:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants