Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_Simplify and ST_SimplifyPreserveTopology #53796

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Sep 1, 2020

Resolves #49036
Resolves #49038
Refs #52013

Release justification: low risk change to new functionality

Release note (sql change): Implement ST_Simplify and
ST_SimplifyPreserveTopology.

@otan otan requested review from sumeerbhola and a team September 1, 2020 22:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan force-pushed the st_simplify branch 2 times, most recently from 09c0345 to 5f1d4b6 Compare September 2, 2020 01:59
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Contributor Author

otan commented Sep 2, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Sep 2, 2020

Merge conflict.

Release justification: low risk change to new functionality

Release note (sql change): Implement ST_Simplify and
ST_SimplifyPreserveTopology.
@otan
Copy link
Contributor Author

otan commented Sep 3, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Sep 3, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants