Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: add ST_LineFromMultiPoint and ST_LineMerge #54013

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

erikgrinaker
Copy link
Contributor

One test case for ST_LineFromMultiPoint is commented out until #53997 is resolved - this may fail and need code changes.

Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): Implement the geometry builtins
ST_LineFromMultiPoint and ST_LineMerge.

Closes #48970.
Closes #48974.

Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): Implement the geometry builtins
`ST_LineFromMultiPoint` and `ST_LineMerge`.
@blathers-crl
Copy link

blathers-crl bot commented Sep 7, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Sep 7, 2020
@blathers-crl blathers-crl bot requested a review from otan September 7, 2020 20:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@otan
Copy link
Contributor

otan commented Sep 8, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 8, 2020

Build succeeded:

@craig craig bot merged commit c119b04 into cockroachdb:master Sep 8, 2020
@erikgrinaker erikgrinaker deleted the linefuncs branch March 19, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_LineMerge({geometry}) geo/geomfn: implement ST_LineFromMultiPoint({geometry})
3 participants