release-20.1: gcjobnotifier: unify gcjobs around a single copy of the system config #54285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@pbardea this is your work, I just ran it through the backport tool |
|
Sorry - missed some cherry-pick skew in the added gcjob_test. Updated my branch. This build will fail on that (and some whitespace linting that should be fixed too). |
ajwerner
force-pushed
the
backport20.1-54266
branch
from
2762594
to
7ddfca3
Compare
Prior to this change, each GC job would hold on to a complete copy of the system config. This was problematic in cases where there were a large number of GC jobs. This PR introduces a new object in a new package to coordinate the relevant notifications. Release note (bug fix): Fixed a bug which could lead to out of memory errors when dropping large numbers of tables at high frequency.
ajwerner
force-pushed
the
backport20.1-54266
branch
from
7ddfca3
to
7a1e981
Compare
|
@pbardea I fixed this up, should be RFAL |
pbardea
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54266.
/cc @cockroachdb/release
Prior to this change, each GC job would hold on to a complete copy of the
system config. This was problematic in cases where there were a large number
of GC jobs. This PR introduces a new object in a new package to coordinate
the relevant notifications.
Release note (bug fix): Fixed a bug which could lead to out of memory errors
when dropping large numbers of tables at high frequency.