backupccl: fix auto-append destination resolution #54460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbardea
requested review from
a team and
miretskiy
and removed request for
a team
|
This change is |
|
This needs more testing, and will rebase on top of #54458. Will follow up when more testing is added. |
miretskiy
approved these changes
Sep 16, 2020
pbardea
force-pushed
the
resolve-fix
branch
5 times, most recently
from
bc02892
to
1d44b6d
Compare
|
Added a suite of tests to test |
This commit fixes a bug where destination resolution to auto-appendable backups would fail if the URI had authentication params specified. Release note (bug fix): In a previous beta, backing up to an auto-appendable directory would not work if authentication parameters were specified in the URI.
pbardea
force-pushed
the
resolve-fix
branch
from
1d44b6d
to
90cb6ea
Compare
|
bors r=miretskiy |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where destination resolution to auto-appendable
backups would fail if the URI had authentication params specified.
Fixes #54455.
Release note (bug fix): In a previous beta, backing up to an
auto-appendable directory would not work if authentication parameters
were specified in the URI.