release-20.2: backupccl: fix descriptor privilege restoration #54854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the privilege descriptor on every restored descriptor are properly reset based on the user that is performing the import. As always, the database descriptor will be reset as if it had just been created. And the table descriptor will inherit the privileges of the database that it is restoring into. The privileges of schemas and types are also now reset. Schemas will have the same behavior as tables and will inherit the privileges of its database (like CREATE SCHEMA). Types will behave like databases and will have privileges as if it was created by the restoring user. Release note (bug fix): Previous versions of 20.2 would not properly clear grants and owners on non-cluster restores.
|
This change is |
dt
approved these changes
Sep 28, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54328.
/cc @cockroachdb/release
This commit ensures that the privilege descriptor on every restored
descriptor are properly reset based on the user that is performing the
import.
As always, the database descriptor will be reset as if it had just been
created. And the table descriptor will inherit the privileges of the
database that it is restoring into. The privileges of schemas and types
are also now reset.
Schemas will have the same behavior as tables and will inherit the
privileges of its database (like CREATE SCHEMA). Types will behave like
databases and will have privileges as if it was created by the restoring
user.
Release note (bug fix): Previous versions of 20.2 would not properly
clear grants and owners on non-cluster restores.