New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix store dir symbolic links #55202
base: master
Are you sure you want to change the base?
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heidawei Can you squash the two commits together? We generally like having the commits be logically coherent units. Having two where one is a bug fix for another isn't very useful.
I'm not sure what is going on with the CLA check. I'll ping someone on our side to take a look.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @petermattis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @heidawei , sometimes the CLA gets stuck. Squashing your commits as @petermattis requested and force pushing should fix it. If it doesn't, another way to fix it is with a command like this:
# Copy a GitHub personal access token into the clipboard and then run this command
curl -H "Authorization: token $(pbpaste)" \
-d '{"state": "success", "context":"license/cla", "description": "curl"}' \
https://api.github.com/repos/cockroachdb/cockroach/statuses/<COMMIT_SHA_TO_UPDATE>
Reviewable status: complete! 0 of 0 LGTMs obtained
This PR bugfix store dir symbolic links for issue 55151