Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix store dir symbolic links #55202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heidawei
Copy link
Contributor

@heidawei heidawei commented Oct 3, 2020

This PR bugfix store dir symbolic links for issue 55151

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 3, 2020

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented Oct 3, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Oct 3, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Oct 3, 2020

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@heidawei
Copy link
Contributor Author

heidawei commented Oct 3, 2020

image

But I have signed the CLA for cockroachdb/cockroach
image

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heidawei Can you squash the two commits together? We generally like having the commits be logically coherent units. Having two where one is a bug fix for another isn't very useful.

I'm not sure what is going on with the CLA check. I'll ping someone on our side to take a look.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @petermattis)

Copy link
Collaborator

@jlinder jlinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @heidawei , sometimes the CLA gets stuck. Squashing your commits as @petermattis requested and force pushing should fix it. If it doesn't, another way to fix it is with a command like this:

# Copy a GitHub personal access token into the clipboard and then run this command
curl -H "Authorization: token $(pbpaste)" \
    -d '{"state": "success", "context":"license/cla", "description": "curl"}' \
    https://api.github.com/repos/cockroachdb/cockroach/statuses/<COMMIT_SHA_TO_UPDATE>

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@tbg tbg added the X-noremind Bots won't notify about PRs with X-noremind label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner X-noremind Bots won't notify about PRs with X-noremind
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants