opt: do not mutate GenerateConstrainedScans input filters #55391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in GenerateConstrainedScans which can cause incorrect query results in tables with a partial index. Filters reduced while proving implication of a partial index would mutate the input filters. These filters would remain mutated for future iterations over other indexes, causing constrained scans to be created without these necessary filters. Fixes cockroachdb#55387 Release justification: This fixes a critical correctness bug for a new feature, partial indexes. Release note (bug fix): A bug was fixed that caused incorrect query results on tables with partial indexes. This bug did not affect any queries involving tables without partial indexes.
|
This change is |
RaduBerinde
approved these changes
Oct 9, 2020
|
bors r=RaduBerinde |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in GenerateConstrainedScans which can cause
incorrect query results in tables with a partial index. Filters reduced
while proving implication of a partial index would mutate the input
filters. These filters would remain mutated for future iterations over
other indexes, causing constrained scans to be created without these
necessary filters.
Fixes #55387
Release justification: This fixes a critical correctness bug for a new
feature, partial indexes.
Release note (bug fix): A bug was fixed that caused incorrect query
results on tables with partial indexes. This bug did not affect any
queries involving tables without partial indexes.