Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-19.2: build: script to make custom builds #55534

Merged
merged 2 commits into from
Oct 14, 2020
Merged

release-19.2: build: script to make custom builds #55534

merged 2 commits into from
Oct 14, 2020

Commits on Oct 14, 2020

  1. build: script to make custom builds 

    Before: We had the old build process and a not-so-great way to make
custom builds.

Why: We have a new build process that includes a facility for making
custom builds and we want it to be very easy to use.

Now:

This script automates much of the process of making a custom build
and makes it very easy to create one on short notice. Comments in the
script describe how to use it and where to go for getting the binaries
and docker image.

This commit also changes the teamcity-make-and-publish-build.sh script
to delete the temporary custombuild- tag and to be consistent in naming
the Build ID.

Release note: None
    @jlinder
    jlinder committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    af1a611 View commit details
    Browse the repository at this point in the history

  2. build: fix builds using grep to match a string. 

    Before: `grep -Eo` was used in a couple places in release scripts
where it might not find the string being searched for, the non-zero
return code wasn't handled and the script should have continued
executing.

Why: The release scripts were erroring out when they should have
continued executing.

Now: The non-zero return code is handled by adding a `|| echo""` to the
commands.

This was discovered by PR cockroachdb#54661 causing master to fail builds in Make
and Publish Build.

Release note: None
    @jlinder
    jlinder committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1cfe9c7 View commit details
    Browse the repository at this point in the history