release-20.1: build: script to make custom builds #55535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: We had the old build process and a not-so-great way to make custom builds. Why: We have a new build process that includes a facility for making custom builds and we want it to be very easy to use. Now: This script automates much of the process of making a custom build and makes it very easy to create one on short notice. Comments in the script describe how to use it and where to go for getting the binaries and docker image. This commit also changes the teamcity-make-and-publish-build.sh script to delete the temporary custombuild- tag and to be consistent in naming the Build ID. Release note: None
Before: `grep -Eo` was used in a couple places in release scripts where it might not find the string being searched for, the non-zero return code wasn't handled and the script should have continued executing. Why: The release scripts were erroring out when they should have continued executing. Now: The non-zero return code is handled by adding a `|| echo""` to the commands. This was discovered by PR cockroachdb#54661 causing master to fail builds in Make and Publish Build. Release note: None
|
This change is |
pbardea
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
#55505 is a bug fix for #54661. Please see individual PRs for details.
/cc @cockroachdb/release