release-20.1: builtins: fix sqrdiff when used as a window function #55999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
yuzefovich
force-pushed
the
backport20.1-55957
branch
2 times, most recently
from
66ecbbb
to
505ea88
Compare
Fix incorrect sqrdiff evaluation due to reuse of the results from previous iterations when used as a window function. Release note (bug fix): CockroachDB previously could incorrectly evaluate sqrdiff function when used as a window function in some cases, and now it is fixed.
We've recently merged a test that in very rare circumstances could produce a float result that differs from the expected one by 1 in the 15th significant digit (after rounding). I believe that could occur, e.g. when the 15th and 16th significant digits were `35`, and we matched the spec of supporting 15 significant digits for floats, yet the rounding makes us return an unexpected result. This commit rounds to the precision of 1 digit less which should make the test non-flaky. Release note: None
yuzefovich
force-pushed
the
backport20.1-55957
branch
from
505ea88
to
21aebcb
Compare
|
It took quite a bit of updating the logic tests ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #55957.
Backport 1/1 commits from #56006.
/cc @cockroachdb/release
builtins: fix sqrdiff when used as a window function
Fix incorrect sqrdiff evaluation due to reuse of the results from
previous iterations when used as a window function.
Fixes: #55944.
Release note (bug fix): CockroachDB previously could incorrectly
evaluate sqrdiff function when used as a window function in some
cases, and now it is fixed.
logictest: deflake a test
We've recently merged a test that in very rare circumstances could
produce a float result that differs from the expected one by 1 in the
15th significant digit (after rounding). I believe that could occur,
e.g. when the 15th and 16th significant digits were
35, and we matchedthe spec of supporting 15 significant digits for floats, yet the
rounding makes us return an unexpected result. This commit rounds to the
precision of 1 digit less which should make the test non-flaky.
Release note: None