release-20.2: importccl: fix INSERT with missing columns with IMPORT PGDUMP #56034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've introduced the functionality in v20.2 to INSERT PGDUMP with less columns than there are total. As a result, we've introduced a bug where missing a column in the INSERT would result in a panic. Release note (bug fix): Fixed a bug where a IMPORTING a PGDUMP with INSERTs not targeting all columns in the database would panic.
|
This change is |
adityamaru
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #55921.
/cc @cockroachdb/release
We've introduced the functionality in v20.2 to INSERT PGDUMP with
less columns than there are total. As a result, we've introduced a bug
where missing a column in the INSERT would result in a panic.
Release note (bug fix): Fixed a bug where a IMPORTING a PGDUMP with
INSERTs not targeting all columns in the database would panic.