Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: server: add license expiry time to prometheus metrics #56463

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

dhartunian
Copy link
Collaborator

Backport 1/1 commits from #55565.

/cc @cockroachdb/release


This change adds a license expiry metric titled
seconds_until_enterprise_license_expiry which contains an integer number of
seconds until the enterprise license expires on the cluster (if one exists). If
no enterprise license is configured, this metric is not appended

This metric is computed on-demand since there is no periodic process that can
regularly update a timeseries for us.

This resolves #52794

Release note (api change): adds a new prometheus metric called
seconds_until_license_expiry that reports on the number of seconds until the
enterprise license on the cluster expires and 0 if there is no license. It will
return a negative number if the expiration is in the past.

This change adds a license expiry metric titled
`seconds_until_enterprise_license_expiry` which contains an integer number of
seconds until the enterprise license expires on the cluster (if one exists). If
no enterprise license is configured, this metric is not appended

This metric is computed on-demand since there is no periodic process that can
regularly update a timeseries for us.

This resolves cockroachdb#52794

Release note (api change): adds a new prometheus metric called
`seconds_until_license_expiry` that reports on the number of seconds until the
enterprise license on the cluster expires and 0 if there is no license. It will
return a negative number if the expiration is in the past.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian dhartunian requested a review from dt November 9, 2020 22:21
@dhartunian
Copy link
Collaborator Author

@dt friendly ping for backport stamp

@dt
Copy link
Member

dt commented Nov 12, 2020

I'm not sure I'm the right reviewer for a backport here -- at first glance this isn't a bug fix so wouldn't usually be something we backport. I haven't been in the relevant discussions of why we need an exception to the backport patch policy so probably makes more sense for whoever has been to stamp it.

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally OK with this PR wrt stability of the change.

However I'd like to understand - what prompted the backport? Is there a customer commitment?

@dhartunian
Copy link
Collaborator Author

@knz yes, there was a request for it on the original PR and I got the impression from Product that there was demand from multiple customers.

@knz
Copy link
Contributor

knz commented Nov 19, 2020

There was a question "will this be backported" and I don't read it as a request (also it was not from product).

Process-wise I'd suggest a summary of the motivation in the PR description
and a review approval by the relevant PM

@thtruo
Copy link
Contributor

thtruo commented Nov 24, 2020

Had a conversation with @dhartunian and Nam so following up on the thread here. We have 2 customers who are waiting on this. Communications were made that this would be available to them in a backport. Could we proceed with this given the business need?

@knz
Copy link
Contributor

knz commented Nov 24, 2020

yeah that sounds good to me 👍

@dhartunian dhartunian merged commit 7a249ce into cockroachdb:release-20.2 Nov 24, 2020
@dhartunian dhartunian deleted the backport20.2-55565 branch November 24, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants