release-20.2: sql: fix panic when showing histograms on all-null columns #56516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, attempting to view statistics for a column in which all values were null could cause the system to panic. This was because the histogram data was empty, and we were trying to decode an empty byte string. This commit fixes the panic by checking if the byte string is empty before trying to decode it, and also ensuring that the column type for the histogram is set even if there are no buckets. Fixes cockroachdb#56356 Release note (bug fix): Fixed a panic that could occur when running `SHOW STATISTICS USING JSON` for a table in which at least one of the columns contained all null values.
|
This change is |
RaduBerinde
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #56434.
/cc @cockroachdb/release
Prior to this commit, attempting to view statistics for a column in which
all values were null could cause the system to panic. This was because the
histogram data was empty, and we were trying to decode an empty byte string.
This commit fixes the panic by checking if the byte string is empty before
trying to decode it, and also ensuring that the column type for the histogram
is set even if there are no buckets.
Fixes #56356
Release note (bug fix): Fixed a panic that could occur when running
SHOW STATISTICS USING JSONfor a table in which at least one of the columnscontained all null values.