release-20.1: pgdate: allow parsing of dates with year 0 #56743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Nov 16, 2020
We support two formats for specifying the year: ISO8601 and AD/BC notation while PG supports only the latter. Year 0000 in ISO is 1 BC in AD/BC, year 0 in AD/BC notation is invalid. Previously we were erroring out if year 0 is used in ISO notation which could lead to internal errors when trying to deserialize a date with year 1 BC, and this is now fixed by allowing year 0 to be used (we still check that it is invalid in AD/BC notation). Release note (bug fix): CockroachDB previously could encounter an internal error when date/timestamp/timestamptz that is of year 1 BC was sent between nodes for execution. Additionally, previously it was not possible to specify the date/timestamp/timestamptz with year 1 BC without using AD/BC notation. This is now fixed.
yuzefovich
force-pushed
the
backport20.1-56636
branch
from
f0b8540
to
5d2fb23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #56636.
/cc @cockroachdb/release
We support two formats for specifying the year: ISO8601 and AD/BC
notation while PG supports only the latter. Year 0000 in ISO is 1 BC in
AD/BC, year 0 in AD/BC notation is invalid. Previously we were erroring
out if year 0 is used in ISO notation which could lead to internal
errors when trying to deserialize a date with year 1 BC, and this is now
fixed by allowing year 0 to be used (we still check that it is invalid
in AD/BC notation).
Fixes: #56554.
Release note (bug fix): CockroachDB previously could encounter an
internal error when date/timestamp/timestamptz that is of year 1 BC was
sent between nodes for execution. Additionally, previously it was not
possible to specify the date/timestamp/timestamptz with year 1 BC
without using AD/BC notation. This is now fixed.